Refactor Python script to one-liner for asset check#3
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the inline Python asset-check script in the release workflow into a single -c one-liner while preserving its behavior of deciding whether release assets are complete and whether a build is needed. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new
python -cone-liner is significantly harder to read and maintain than the previous here-doc script; consider keeping the multi-line Python block or at least splitting the logic into clearer statements (e.g., using a small helper script) to make future changes less error-prone, especially around quoting and asset list updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `python -c` one-liner is significantly harder to read and maintain than the previous here-doc script; consider keeping the multi-line Python block or at least splitting the logic into clearer statements (e.g., using a small helper script) to make future changes less error-prone, especially around quoting and asset list updates.
## Individual Comments
### Comment 1
<location path=".github/workflows/release.yml" line_range="77" />
<code_context>
-if required.issubset(assets):
- raise SystemExit(0)
-
-print("Required release assets missing, build needed.", file=sys.stderr)
-raise SystemExit(1)
-PY
</code_context>
<issue_to_address>
**issue:** The new version no longer prints a diagnostic message when required assets are missing, reducing debuggability.
Previously this script wrote a clear stderr message before exiting with status 1; now it fails silently, which makes CI logs harder to interpret. Please keep a brief stderr message (e.g., just before `sys.exit(1)`) so it’s obvious in logs why the build was triggered.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements: